-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go] Add client batching integration tests #1555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have this test in. Hopefully it shouldn't take too long to execute on CI.
TIGERBEETLE_CLUSTER_ID uint64 = 0 | ||
TIGERBEETLE_REPLICA_ID uint32 = 0 | ||
TIGERBEETLE_REPLICA_COUNT uint32 = 1 | ||
TIGERBEETLE_CONCURRENCY_MAX uint = 4096 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump this to 8192 to reflect the value in tb_client/context.zig
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the way we handle TooManyOutstanding
isn't quite right. This test exposes a bug when running with concurrency_max
higher than the size of the DemuxPool
(which is 4096).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. tb_client wasn't adjusted properly after DemuxPool was introduced. It should be addressed by the intrusive packets PR at least.
Yes, it took just a few seconds (< 10s) to run. |
No description provided.